This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
Minor Consistency Fixes for Meetings/Events/Projects #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernep
changed the title
|
So having the group name in the meeting title is actually way harder than I expected, and also probably has a pretty severe performance impact on pages with a lot of meetings. So I'm thinking it's not worth doing. |
rushsteve1
approved these changes
Nov 25, 2019
|
Do we want that consistency between event and meeting names on the attendance summary or should we just leave the event names up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#100 #65
Describe the Changes
This is just a minor consistency fix between my original Pull Request and @rushsteve1 's changes/additions to meetings and events since then.
Still To Do
We still need to add the group name for meetings on the Attendance Summary, similar to what we already have for events on the Attendance Summary.
I got errors when I attempted to query the group names (because I'm not entirely sure how to do this), @rushsteve1 hopefully knows a quick way of doing it. I was specifically trying to change the name() function under Attendable in the groups/models.rs file.
Problems
None
Acknowledgements
@rushsteve1 Hopefully he can address the above issue.